Skip to content

Conversation

@mw-root
Copy link

@mw-root mw-root commented Jan 13, 2026

Description

This change allows consumers to skip pip installation by setting the install-pip input to false (or really, anything other than true).

This can speed up the action by around 5sec for those who don't need to use pip.

closes #29

@mw-root
Copy link
Author

mw-root commented Jan 16, 2026

@kishaningithub the way you're doing checkout in your workflows doesn't appear to work on forked repos.

Is there a reason why you provide so many inputs instead of just doing a vanilla checkout with the depth setting aren't using the checkout action?

@kishaningithub
Copy link
Owner

@mw-root The checkout action does not work within amazon linux 2 container which this action supports

@mw-root
Copy link
Author

mw-root commented Jan 16, 2026

@kishaningithub that makes sense.

It appears that there's probably required changes for this to work from forked repos.

I have an example of what actions/checkout does in these cases in the checkout step of this workflow here

I've reproduced this for this PR and validated it pulls the change.

git init
git remote add origin https://github.com/kishaningithub/setup-python-amazon-linux
git fetch origin +3e3a03020af3dac49dd22456c1a702b5a444ae3a:refs/remotes/pull/30/merge # +{commit sha}:{ref}
git checkout --progress --force refs/remotes/pull/30/merge

❯ yq .inputs < action.yml

install-pip:
  description: 'Whether to install pip. Default true.'
  default: 'true'
python-version:
  description: 'Version of python to be installed. Reads from python-version-file if unset.'
python-version-file:
  description: 'Version of python to be installed'
  default: '.python-version'
cache:
  description: >
    [Deprecated] Used to specify whether caching is needed. Set to true, if you'd like to enable caching. Current implementation uses uv which pulls in pre-compiled binaries of python thereby eliminating the need to cache compiled python artifacts.

  default: 'true'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow Consumers to Skip Pip Installation

2 participants